proposal: x/tools/cmd/deadcode: Notify OS of exit code 2,1 when unreachable code is found

[Hyuga-Tsukui]

Proposal Details

The deadcode command is quite useful but not well-suited for execution in automated environments such as CI. This is because, even when it discovers unreachable code, it only outputs the list of findings to standard error without sending an exit code.

In this proposal, I suggest properly implementing exit notifications to the OS for the deadcode command, motivated by its usage scenarios.

The implementation could be straightforward: at the end of the main function, simply call os.Exit(2) if the length of the output list of unreachable code is greater than zero.

[gopherbot]

Change https://go.dev/cl/568175 mentions this issue: cmd/deadcode: return an end code.

[mauri870]

Thanks for opening a proposal. We already discussed this previously in issue #64713.

I don't think anything changed regarding the decision that was taken there, so I'm marking this as a duplicate.

[mauri870]

Duplicate of #64713.