x/pkgsite: std's reflect expands with zero subpackages in the directory view

[mvdan]

What is the URL of the page with the issue?

https://pkg.go.dev/std

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:132.0) Gecko/20100101 Firefox/132.0

Screenshot

What did you do?

Tried expanding a number of std packages in the directory view to see subpackages.

What did you see happen?

Any package with the arrow pointing right should expand with subpackages when clicking on the arrow.

What did you expect to see?

Most packages do that, except reflect, which expands into nothing.

This might be because reflect only has internal sub-packages:

$ go list reflect/...
reflect
reflect/internal/example1
reflect/internal/example2

[hyangah]

There are internal/example1 and internal/exmple2 packages underneath in the html table which become visible when click on "Show Internal".

[mvdan]

I see. My intuition is that the dropdown UI should not appear unless it actually expands into something. So perhaps the dropdown should appear only when enabling "show internal".

[gopherbot]

Change https://go.dev/cl/673717 mentions this issue: static/frontend: hide subpackage expansion button when all internal

[jakebailey]

This finally bugged me enough to send a CL 😄