x/tools/gopls: Definition: "no metadata for package 'unsafe'" bug

[adonovan]

#!stacks
"bug.Errorf" && "golang.builtinDecl:+63"

Issue created by stacks.

	if obj.Pkg() == types.Unsafe {
		// package "unsafe":
		// parse $GOROOT/src/unsafe/unsafe.go
		//
		// (Strictly, we shouldn't assume that the ID of a std
		// package is its PkgPath, but no Bazel+gopackagesdriver
		// users have complained about this yet.)
		unsafe := snapshot.Metadata("unsafe")
		if unsafe == nil {
			// If the type checker somehow resolved 'unsafe', we must have metadata
			// for it.
			return nil, nil, bug.Errorf("no metadata for package 'unsafe'")
		}

This stack vDHSJA was reported by telemetry:

• gopls/bug
• golang.org/x/tools/gopls/internal/util/bug.report:+35
• golang.org/x/tools/gopls/internal/util/bug.Errorf:+2
• golang.org/x/tools/gopls/internal/golang.builtinDecl:+63
• golang.org/x/tools/gopls/internal/golang.builtinDefinition:+1
• golang.org/x/tools/gopls/internal/golang.Definition:+66
• golang.org/x/tools/gopls/internal/server.(*server).Definition:+19
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+215
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
• golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
• golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
• runtime.goexit:+0

golang.org/x/tools/gopls@v0.17.1 go1.23.4 darwin/arm64 vscode (1)

[gabyhelp]

Related Issues

• x/tools/gopls: Hover: invalid nil entry in types.Defs map #69362 (closed)
• x/tools/gopls: "unexpected files in command-line-arguments package" bug (via telemetry) #64557
• x/tools/gopls: `encountered "unsafe" as %s` bug (via telemetry) #67751 (closed)
• x/tools/gopls: "go/packages failed to return non-test standalone package" bug (reported by telemetry) #66204 (closed)
• x/tools/gopls: analysisinternal.ZeroValue crash on (presumably) unsafe.Pointer #70585 (closed)
• x/tools/gopls: "inline: corrupted reference %v" bug in golang.RemoveUnusedParameter #69896 (closed)
• x/tools/gopls: Hover: nil deref in parseDocLink #70635 (closed)
• x/tools/gopls: Completion: failed type assertion in completer.item #71044 (closed)
• x/tools/gopls: Hover: nil deref in golang.StdSymbolOf #70969 (closed)
• x/tools/gopls: nil Signature (?) deref in Completion #70634 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}