present: support markdown table #219

ddatsh · 2020-03-29T12:41:28Z

No description provided.

gopherbot · 2020-03-29T12:58:00Z

This PR (HEAD: 7c1df7d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-03-30T16:01:16Z

Message from Rebecca Stambler:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-30T16:01:17Z

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=bca07cc9

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-30T16:10:46Z

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-30T21:40:47Z

Message from Andrew Bonventre:

Patch Set 1: Run-TryBot+1

(1 comment)

+rsc

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-30T21:40:48Z

Message from Andrew Bonventre:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-31T02:45:19Z

This PR (HEAD: 5fd3dbf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-03-31T02:48:19Z

This PR (HEAD: 166b17f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-03-31T02:49:45Z

This PR (HEAD: 0bbdd35) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-03-31T03:01:31Z

Message from peter zhang:

Patch Set 5:

please review again

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-31T12:07:10Z

Message from Russ Cox:

Patch Set 5:

Please add a test in testdata/table.md so we don't break this functionality in the future.
Otherwise seems fine. Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-31T12:13:46Z

Message from Russ Cox:

Patch Set 5:

Also if you could please change your Author line to use the full name we have in the CONTRIBUTORS file (Peter Zhang), that would help us when looking through history.

git commit --amend --author='Peter Zhang [email protected]'
should do it.

Thanks again.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-31T12:53:42Z

Message from peter zhang:

Patch Set 5:

done

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-31T12:53:47Z

This PR (HEAD: e54f61b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/226208 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-05-27T16:45:41Z

Message from Andrew Bonventre:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-27T16:47:09Z

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=67e5159e

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-27T16:50:00Z

Message from Gobot Gobot:

Patch Set 6:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/748533e3/freebsd-amd64-12_0_1768acf2.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-27T16:56:32Z

Message from Gobot Gobot:

Patch Set 6: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-27T17:06:05Z

Message from Andrew Bonventre:

Patch Set 7: Patch Set 6 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-27T17:06:06Z

Message from Andrew Bonventre:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-27T17:06:07Z

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=314f4c0a

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-27T17:08:58Z

Message from Gobot Gobot:

Patch Set 7:

Build is still in progress...
This change failed on linux-386:
See https://storage.googleapis.com/go-build-log/e3491c46/linux-386_52a30909.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-27T17:18:55Z

Message from Gobot Gobot:

Patch Set 7: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-27T17:31:25Z

Message from Andrew Bonventre:

Patch Set 7: -Run-TryBot

The tests are failing. Please take a look and fix before we can move forward. Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:59Z

Message from Russ Cox:

Patch Set 5:

Also if you could please change your Author line to use the full name we have in the CONTRIBUTORS file (Peter Zhang), that would help us when looking through history.

git commit --amend --author='Peter Zhang [email protected]'
should do it.

Thanks again.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T10:59:59Z

Message from peter zhang:

Patch Set 5:

done

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:00Z

Message from Andrew Bonventre:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:01Z

Message from Go Bot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=67e5159e

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:02Z

Message from Go Bot:

Patch Set 6:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/748533e3/freebsd-amd64-12_0_1768acf2.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:03Z

Message from Go Bot:

Patch Set 6: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:04Z

Message from Andrew Bonventre:

Patch Set 7: Patch Set 6 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:05Z

Message from Andrew Bonventre:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:06Z

Message from Go Bot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=314f4c0a

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:07Z

Message from Go Bot:

Patch Set 7:

Build is still in progress...
This change failed on linux-386:
See https://storage.googleapis.com/go-build-log/e3491c46/linux-386_52a30909.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:08Z

Message from Go Bot:

Patch Set 7: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:09Z

Message from Andrew Bonventre:

Patch Set 7: -Run-TryBot

The tests are failing. Please take a look and fix before we can move forward. Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:10Z

Message from peter zhang:

Patch Set 8:

Run-TryBot = +1

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:11Z

Message from peter zhang:

Patch Set 8:

Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:12Z

Message from peter zhang:

Patch Set 8:

(1 comment)

Patch Set 7: -Run-TryBot

The tests are failing. Please take a look and fix before we can move forward. Thanks.

rebase my branch to origin master, please try again?

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:13Z

Message from Andrew Bonventre:

Patch Set 9: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:14Z

Message from Go Bot:

Patch Set 9:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ed855db4

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:15Z

Message from Go Bot:

Patch Set 9:

Build is still in progress...
This change failed on linux-amd64:
See https://storage.googleapis.com/go-build-log/0d20a492/linux-amd64_ff40c590.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:16Z

Message from Go Bot:

Patch Set 9: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:17Z

Message from Andrew Bonventre:

Patch Set 9: -Run-TryBot

Have you tried running go test to ensure your changes are passing locally?

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:17Z

Message from Andrew Bonventre:

Patch Set 10: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:18Z

Message from Go Bot:

Patch Set 10:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=b543033c

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:19Z

Message from Go Bot:

Patch Set 10:

Build is still in progress...
This change failed on linux-amd64 (Go 1.13.x):
See https://storage.googleapis.com/go-build-log/90fe4a73/linux-amd64_0932d75e.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:20Z

Message from peter zhang:

Patch Set 10:

@andrew,I try to understand parse_test logic

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:21Z

Message from Go Bot:

Patch Set 10: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:22Z

Message from peter zhang:

Patch Set 10:

test passed, please try again

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:23Z

Message from Andrew Bonventre:

Patch Set 11: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:25Z

Message from Go Bot:

Patch Set 11:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=80c61e04

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:00:25Z

Message from Go Bot:

Patch Set 11: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/226208.
After addressing review feedback, remember to publish your drafts!

muly · 2023-11-18T01:04:16Z

hello, any progress on this PR. I'm looking forward for a solution to add a table to present presentation .

googlebot added the cla: yes label Mar 29, 2020

ddatsh force-pushed the master branch from 7c1df7d to 5fd3dbf Compare March 31, 2020 02:45

ddatsh force-pushed the master branch from 5fd3dbf to 166b17f Compare March 31, 2020 02:47

ddatsh force-pushed the master branch from 166b17f to 0bbdd35 Compare March 31, 2020 02:49

ddatsh force-pushed the master branch from 0bbdd35 to e54f61b Compare March 31, 2020 12:51

ddatsh force-pushed the master branch from e54f61b to 87ddc87 Compare May 28, 2020 01:06

present: support markdown table #219

Are you sure you want to change the base?

present: support markdown table #219

Conversation

ddatsh commented Mar 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Mar 29, 2020

Uh oh!

gopherbot commented Mar 30, 2020

Uh oh!

gopherbot commented Mar 30, 2020

Uh oh!

gopherbot commented Mar 30, 2020

Uh oh!

gopherbot commented Mar 30, 2020

Uh oh!

gopherbot commented Mar 30, 2020

Uh oh!

gopherbot commented Mar 31, 2020

Uh oh!

gopherbot commented Mar 31, 2020

Uh oh!

gopherbot commented Mar 31, 2020

Uh oh!

gopherbot commented Mar 31, 2020

Uh oh!

gopherbot commented Mar 31, 2020

Uh oh!

gopherbot commented Mar 31, 2020

Uh oh!

gopherbot commented Mar 31, 2020

Uh oh!

gopherbot commented Mar 31, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented May 27, 2020

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

ddatsh commented Mar 29, 2020 •

edited

Loading