Fix example of specifying value received method in -funcs
#236
Conversation
My experimentation shows that `dir/pkg.Type.Method` doesn't work, but `(dir/pkg.Type).Method` does. Looking at https://golang.org/pkg/go/types/#Func.FullName implementation: https://github.com/golang/go/blob/18bcc7c2854f900dfb631d7ef01a839021e24576/src/go/types/object.go#L465-L486 it seems to me that in both cases of pointer and value received the brackets are written.
|
This PR (HEAD: c2eec4e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/239498 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/239498. |
|
Message from Michael Matloob: Patch Set 1: Could this be accompanied with a test? Please don’t reply on this GitHub thread. Visit golang.org/cl/239498. |
|
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/239498. |
My experimentation shows that
dir/pkg.Type.Methoddoesn't work, but(dir/pkg.Type).Methoddoes.Looking at https://golang.org/pkg/go/types/#Func.FullName implementation:
https://github.com/golang/go/blob/18bcc7c2854f900dfb631d7ef01a839021e24576/src/go/types/object.go#L465-L486
it seems to me that in both cases of pointer and value received the brackets are written.
CC: @alandonovan