Skip to content

Initial commit for BISON-style token location tracking #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Initial commit for BISON-style token location tracking #295

wants to merge 11 commits into from
+134 −7

Conversation

danswartzendruber
Copy link

No description provided.

@google-cla google-cla bot added the cla: yes label Mar 31, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 414fb5e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/306050 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Matthew Dempsky:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Dempsky:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Dempsky:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@danswartzendruber
Address audit issues
29e4dee 
Eliminate changes which implemented the '-tflag' command line switch, as being unnecessary, along with the API change to the Lex and Error methods.
@gopherbot
Copy link
Contributor

This PR (HEAD: 29e4dee) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/306050 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@danswartzendruber
Update yacc.go
501910c 
Diagnose @n if N is not in the range 1-9.
@gopherbot
Copy link
Contributor

This PR (HEAD: 501910c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/306050 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@danswartzendruber
Update yacc.go
b16c675 
Improve range-checking for @ pseudo-variables.
@gopherbot
Copy link
Contributor

This PR (HEAD: b16c675) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/306050 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@danswartzendruber
Update yacc.go
702692f 
@ Change pseudo-variable parsing to correctly diagnose non-decimal integer operand.
@gopherbot
Copy link
Contributor

This PR (HEAD: 702692f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/306050 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Matthew Dempsky:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Dempsky:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jakob Maier:

Patch Set 5: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jakob Maier:

Patch Set 5: -Code-Review

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 5:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jakob Maier:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jakob Maier:

Patch Set 5: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jakob Maier:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 2f9cb88) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/306050 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Dan Swartzendruber:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 06376b2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/306050 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/306050.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 72891d2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/306050 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GypsyTheDj GypsyTheDj GypsyTheDj approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danswartzendruber @gopherbot @GypsyTheDj @110y