Skip to content

internal/imports: remove duplicate unused imports #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

internal/imports: remove duplicate unused imports #299

wants to merge 1 commit into from
+42 −27

Conversation

Deiz
Copy link
Contributor

@Deiz Deiz commented Apr 5, 2021

Track imports per identifier as a slice to accommodate duplicates. This
allows us to generate multiple import fixes per import identifier.

Fixes golang/go#45398

@Deiz
internal/imports: remove duplicate unused imports
79f5729 
Track imports per identifier as a slice to accommodate duplicates. This
allows us to generate multiple import fixes per import identifier.

Fixes golang/go#45398
@google-cla google-cla bot added the cla: yes label Apr 5, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 79f5729) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/307449 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=6557c927

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/deda36c2-b38e-4079-8756-0fead95faad5

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/deda36c2-b38e-4079-8756-0fead95faad5

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

@Deiz
Copy link
Contributor Author

Deiz commented Oct 15, 2021

@heschi anything blocking merge on this?

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=6557c927

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/deda36c2-b38e-4079-8756-0fead95faad5

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/deda36c2-b38e-4079-8756-0fead95faad5

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/307449.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 29, 2023
@Deiz @gopherbot
internal/imports: remove duplicate unused imports
1b1e4da 
Track imports per identifier as a slice to accommodate duplicates. This
allows us to generate multiple import fixes per import identifier.

Fixes golang/go#45398

Change-Id: I78b80efabefc2263251c0087a0f2dc688f708de3
GitHub-Last-Rev: 79f5729
GitHub-Pull-Request: #299
Reviewed-on: https://go-review.googlesource.com/c/tools/+/307449
Auto-Submit: Robert Findley <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/tools/imports: Process does not remove all unused imports sharing a package name
2 participants
@Deiz @gopherbot