Skip to content

godoc/server: show internal packages switch #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

godoc/server: show internal packages switch #312

wants to merge 5 commits into from
+100 −27

Conversation

TomFreudenberg
Copy link
Contributor

@TomFreudenberg TomFreudenberg commented Apr 25, 2021 •
edited
Loading

New command flag -show_internal_pkg will show the master
internal packages in general without url modifier ?m=all

In addition the GOMOD mode is updated to respect the
components inside modules path as GOROOT components.

@TomFreudenberg
rewrite listing: filter on DirEntry, respect GoRoot
12f40c8 
passes the full prepared DirEntry to filter() to enable different
filtering for GoRoot and GoPath packages etc.

check if the first entry in 'Standard library' should be prefixed by a
path while coming from go.mod module
@TomFreudenberg
flag to show 'internal' pkg as default
d7b5826
@TomFreudenberg
flag to show internal pkg, respect go.mod module
b1d71b5 
additional flag per command line to show the internal
packages per default and not only by '?m=all'. This is
only enabled for the 'Standard library' but not 'Third party'

identify the go.mod module if running in GOMOD mode. If
detected check the RootType based on module path in
moduleFS. Last exclude the /cmd/ from modules package
view.
@TomFreudenberg
extended filter to include path
d0dbf8f 
respect new flag to show internal packages per default

optionl invisible content from third_party path
@google-cla google-cla bot added the cla: yes label Apr 25, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: d0dbf8f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/313094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@TomFreudenberg TomFreudenberg changed the title Features for godoc to show packages godoc/server: show internal packages switch Apr 27, 2021
@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tom Thomas Freudenberg:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tom Thomas Freudenberg:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tom Freudenberg:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tom Freudenberg:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tom Freudenberg:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 33e34eb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/313094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Dmitri Shuralyov:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tom Freudenberg:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tom Freudenberg:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tom Freudenberg:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/313094.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomFreudenberg @gopherbot