Skip to content

internal/lsp/cache: improve open out of workspace file full parse. #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavlelee
Copy link

@pavlelee pavlelee commented Sep 2, 2021

Normal mode solves the problem of excessive memory consumption, but if my machine has enough memory, I still want a complete code prompt experience

@google-cla google-cla bot added the cla: yes label Sep 2, 2021
@pavlelee
Copy link
Author

pavlelee commented Sep 2, 2021

fix golang/go#47660

@gopherbot
Copy link
Contributor

This PR (HEAD: 74a49fb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/347210 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/347210.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: c0b1bca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/347210 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: aa948bf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/347210 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Normal mode solves the problem of excessive memory consumption, but if my machine has enough memory, I still want a complete code prompt experience.
@gopherbot
Copy link
Contributor

This PR (HEAD: aeffa5b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/347210 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 4: Code-Review-2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347210.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Pavle Lee:

Patch Set 4: Code-Review+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347210.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Pavle Lee:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347210.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Pavle Lee:

Patch Set 4: -Code-Review

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347210.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants