-
Notifications
You must be signed in to change notification settings - Fork 2.3k
go/analysis/passes/nilness: fix wrong internal code comment #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/analysis/passes/nilness: fix wrong internal code comment #502
Conversation
This PR (HEAD: 3c1c906) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/595895. Important tips:
|
Message from Tim King: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Tim King: Patch Set 1: -Code-Review Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-01T20:34:31Z","revision":"02659a16d286ece0354f0059a3e4d3f77a0fdce7"} Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Tim King: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
This PR (HEAD: 63b4523) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/595895. Important tips:
|
This PR (HEAD: 9a14c39) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/595895. Important tips:
|
Message from Gopher Robot: Patch Set 4: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Tim King: Patch Set 4: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-02T19:16:25Z","revision":"3016b49ef6ca13746449ac7649105725879848db"} Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Tim King: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Aung Ko: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Tim King: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
This PR (HEAD: 9ab1372) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/595895. Important tips:
|
Message from Tim King: Patch Set 6: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Michael Matloob: Patch Set 6: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Michael Matloob: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-07-12T21:18:51Z","revision":"cc47519c9ecfd6cc38b69c9cd403217daa95d7ac"} Please don’t reply on this GitHub thread. Visit golang.org/cl/595895. |
I fixed wrong internal code comment. Change-Id: I1c3e383583a7a95070c56adc7b034b6874cce5d2 GitHub-Last-Rev: 9ab1372 GitHub-Pull-Request: #502 Reviewed-on: https://go-review.googlesource.com/c/tools/+/595895 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Matloob <[email protected]> Reviewed-by: Tim King <[email protected]>
This PR is being closed because golang.org/cl/595895 has been merged. |
I fixed wrong internal code comment.