Skip to content

Run the build after dependabot PR #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Run the build after dependabot PR #54

merged 2 commits into from
Jul 14, 2020

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jul 14, 2020

A few dependabot PRs are merged recently. However, the build in those PR might not reflect what we have in repo due to files in dist directory. So this PR is just for npm run all from master branch.

#52
#53

@SVilgelm
Copy link
Member

SVilgelm commented Jul 14, 2020

the prettier was updated, probably you just need to run npm install

@SVilgelm
Copy link
Member

I did rebase for all prs before merging

@sayboras
Copy link
Member Author

I did rebase for all prs before merging

Yes, I am aware of that. This PR is just to re-generate files in dist/ directory. As during the build, I don't think we automatically commit if there is any changes.

@SVilgelm
Copy link
Member

yeah, we need to block merging without rebuilding

@sayboras
Copy link
Member Author

sayboras commented Jul 14, 2020

yeah, we need to investigate how to automate this as well. The main entry point is coming from this line https://github.com/golangci/golangci-lint-action/blob/master/action.yml#L27

@sayboras sayboras merged commit ba40dc6 into golangci:master Jul 14, 2020
@sayboras sayboras deleted the feature/build-after-dependabot branch July 14, 2020 23:15
@SVilgelm
Copy link
Member

we can do for any push to master branch run npm run all and if the files in dist folder were changed, then just make a direct commit to the master branch using. But we need a GitHub token with admin permissions for this repo

@SVilgelm
Copy link
Member

or just block from merging, so someone need to do it manually and update a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants