Build errors using Go 1.13

[bvwells]

I'm currently getting build errors (master branch) trying to build golangci-lint with Go 1.13.

The build error is:
go: github.com/golangci/bodyclose@v0.0.0-20190713050349-65da19158fa2: invalid pseudo-version: does not match version-control timestamp (2019-07-14T14:40:26Z)

Here are a few details of my go env:
GOARCH=amd64
GOOS=windows

Let me know if you need any more details to reproduce.

The reason I came across this is that go get with go 1.13 returns the errors below and I thought I'd try to use a locally build version of golangci-lint.

go get -u github.com/golangci/golangci-lint/cmd/golangci-lint
verifying github.com/golangci/ineffassign@v0.0.0-20180808204949-42439a7714cc/go.mod: github.com/golangci/ineffassign@v0.0.0-20180808204949-42439a7714cc/go.mod: reading https://sum.golang.org/lookup/github.com/golangci/ineffassign@v0.0.0-20180808204949-42439a7714cc: 410 Gone
verifying github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540/go.mod: github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540/go.mod: reading https://sum.golang.org/lookup/github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: 410 Gone

[panchoh]

Same issue here, on archlinux, when building v1.17.1.
master builds OK, though.

$ GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.17.1
go: finding github.com v1.17.1
go: finding github.com/golangci/golangci-lint/cmd v1.17.1
go: finding github.com/golangci v1.17.1
go: finding github.com/golangci/golangci-lint/cmd/golangci-lint v1.17.1
go get: github.com/golangci/golangci-lint@v1.17.1 requires
	github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: invalid pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19Z)

[brunetto]

Master branch doesn't build for me with go1.13 (on mac)

$ go version
go version go1.13 darwin/amd64
$ git clone git@github.com:golangci/golangci-lint.git
$ cd golangci-lint/cmd/golangci-lint
$ go build
go: github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: invalid pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19Z)

[lunemec]

There were changes in go.mod, try running go mod tidy and also setting go version to 1.13 with go mod edit -go=1.13.

[brunetto]

Doesn't seems to work either...

$ go mod tidy
go: github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: invalid pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19Z)

$ go mod edit -go=1.13

$ go mod tidy
go: github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: invalid pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19Z)

$ go build
go: github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: invalid pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19Z)

[lwaddicor]

I'm getting the same thing

Go build gives me the same thing:
$ go build
go: github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: invalid pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19Z)



Go mod tidy gives this:
$ go mod tidy
go: github.com/golangci/bodyclose@v0.0.0-20190713050349-65da19158fa2: invalid pseudo-version: does not match version-control timestamp (2019-07-14T14:40:26Z)

[brunetto]

Ok, I've been able to have the master building recreating the go.mod.

A better (less lazy) way is to look here c3a532e

[thepudds]

If we follow the advice from the section of the Go 1.13 release notes on resolving invalid pseudo-version errors (https://golang.org/doc/go1.13#version-validation), we can make the go get work for v1.17.1:

   # first, setup from scratch

   export GOPATH=$(mktemp -d)               # using fresh module cache
   cd $(mktemp -d)                   
   go mod init example.com/tempmod

   # second, create 'replace' statements using *just* the commit hashes 
   # for each problematic module on the right-hand side

   echo 'replace github.com/go-critic/go-critic v0.0.0-20181204210945-1df300866540 => github.com/go-critic/go-critic 1df300866540' >> go.mod
   echo 'replace github.com/golangci/errcheck v0.0.0-20181003203344-ef45e06d44b6 => github.com/golangci/errcheck ef45e06d44b6' >> go.mod
   echo 'replace github.com/golangci/go-tools v0.0.0-20180109140146-af6baa5dc196 => github.com/golangci/go-tools af6baa5dc196' >> go.mod
   echo 'replace github.com/golangci/gofmt v0.0.0-20181105071733-0b8337e80d98 => github.com/golangci/gofmt 0b8337e80d98' >> go.mod
   echo 'replace github.com/golangci/gosec v0.0.0-20180901114220-66fb7fc33547 => github.com/golangci/gosec 66fb7fc33547' >> go.mod
   echo 'replace github.com/golangci/ineffassign v0.0.0-20180808204949-42439a7714cc => github.com/golangci/ineffassign 42439a7714cc' >> go.mod
   echo 'replace github.com/golangci/lint-1 v0.0.0-20180610141402-ee948d087217 => github.com/golangci/lint-1 ee948d087217' >> go.mod
   echo 'replace mvdan.cc/unparam v0.0.0-20190124213536-fbb59629db34 => mvdan.cc/unparam fbb59629db34' >> go.mod

This now works:

   go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.17.1

[bcmills]

Duplicate of #652

[powerman]

Another way to install 1.17.1, with working --version flag like in released binaries:

GO111MODULE=off go get -d github.com/golangci/golangci-lint/cmd/golangci-lint
cd $(go env GOPATH)/src/github.com/golangci/golangci-lint
git checkout v1.17.1
go install -ldflags "-s -w -X main.version=1.17.1 -X main.commit=4ba2155 -X main.date=2019-06-10T09:06:49Z" ./cmd/golangci-lint