result/processors: treat all non-Go source as special autogenerated files #1544
Conversation
…iles Prior to this change golangci-lint would attempt to follow //line directives into generation description files unless they were in a small set of fake files used by goyacc. Now we consider all non-Go source as special.
|
I don't know the history behind this but it surprises me why the old implementation only skips some files. It feels very obvious to skip every non Go file. I can't get Go code without It would be interesting to see why those files are picked up since it would make sense if every non Go file was filtered out by the analysis package. I will approve this but would love more insight in how this actually works. I know for a fact when helping out with gochecknoglobals I had to manually skip non Go files since the analyzer picks up generated code created by |
| // fake files to which //line points to for goyacc generated files | ||
| return fileName == "yacctab" || fileName == "yaccpar" || fileName == "NONE" | ||
| // fake files or generation definitions to which //line points to for generated files | ||
| return filepath.Ext(fileName) != ".go" |
There was a problem hiding this comment.
maybe filepath.Ext(filePath) != ".go" is good enough.
There was a problem hiding this comment.
Actually, if we are comparing the full path we can avoid filepath and skip calling into OS specific code and just do strings.HaveSuffix(filePath, ".go"). Maybe we can save a microsecond or three? 😄
I imagine that it's because the |
Prior to this change golangci-lint would attempt to follow
//linedirectives into generation description files unless they were in a small set of fake files used by goyacc. Now we consider all non-Go source as special.Fixes #1543