Skip to content

Update assets for v1.34.0 #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2020
Merged

Update assets for v1.34.0 #1588

merged 2 commits into from
Dec 28, 2020

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented Dec 28, 2020 •
edited
Loading

Signed-off-by: Denis Tingajkin [email protected]

Fixes: https://github.com/golangci/golangci-lint/runs/1618093797

This pr just makes

make assets/github-action-config.json
make update_netlify_state
make update_contributors_list

@ldez ldez self-requested a review December 28, 2020 16:29
@ldez ldez self-assigned this Dec 28, 2020
@ldez ldez changed the title fix: Prepare generated staff for v1.34.0 fPrepare generated stuff for v1.34.0 Dec 28, 2020
@ldez ldez changed the title fPrepare generated stuff for v1.34.0 Prepare generated stuff for v1.34.0 Dec 28, 2020
@ldez ldez added the area: ci PR that update CI label Dec 28, 2020
SVilgelm
SVilgelm requested changes Dec 28, 2020
View reviewed changes
Copy link
Member

@SVilgelm SVilgelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, the 1.34.0 is release, so this must contain v1.34.0 in assets

@ldez
Copy link
Member

ldez commented Dec 28, 2020

https://github.com/orgs/golangci/teams/team/discussions/5/comments/31

@denis-tingaikin
generate stuff for v1.34.0
78be2ae 
Signed-off-by: Denis Tingajkin <[email protected]>
@denis-tingaikin
Copy link
Member Author

https://github.com/orgs/golangci/teams/team/discussions/5/comments/32

PR is updated for v1.34.0

ldez
ldez approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denis-tingaikin denis-tingaikin changed the title Prepare generated stuff for v1.34.0 Regenerate stuff for v1.34.0 Dec 28, 2020
SVilgelm
SVilgelm requested changes Dec 28, 2020
View reviewed changes
Copy link
Member

@SVilgelm SVilgelm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog file. It's used in the generating the change log in the roadmap section: https://golangci-lint.run/product/roadmap/#changelog

@denis-tingaikin
Copy link
Member Author

@SVilgelm Change log file was not updated since September... So I think it can be done in separate PR.

@ldez
Copy link
Member

ldez commented Dec 28, 2020

@SVilgelm this step is not documented in the process page https://golangci-lint.run/contributing/workflow/#new-releases

Maybe we have to improve a bit this documentation page.

@ldez
Copy link
Member

ldez commented Dec 28, 2020

@denis-tingajkin I will update your PR to add this chnagelog.

@denis-tingaikin
Copy link
Member Author

@ldez I feel this still can be done in separate PR :)

@SVilgelm
Copy link
Member

@denis-tingajkin we are not in rush, let's do it here, especially @ldez wants to do it

@denis-tingaikin
Copy link
Member Author

@SVilgelm OK, Could you improve documentation for releases and add a point about the change log?

@SVilgelm
Copy link
Member

@SVilgelm OK, Could you improve documentation for releases and add a point about the change log?

I will check, I didn't work on this projects since September, need to check what was changed

@ldez ldez changed the title Regenerate stuff for v1.34.0 Update assets for v1.34.0 Dec 28, 2020
SVilgelm
SVilgelm approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@SVilgelm SVilgelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you

@ldez
Copy link
Member

ldez commented Dec 28, 2020

Updating a changelog of this type by hand is great pain.

It is impossible to maintain it properly.

We have to change this in order to use the changelog generated during releases and stop with the months.

@SVilgelm
Copy link
Member

SVilgelm commented Dec 28, 2020 •
edited
Loading

Updating a changelog of this type by hand is great pain.

It is impossible to maintain it properly.

We have to change this in order to use the changelog generated during releases and stop with the months.

agree, but it's what we have now
And it's not so hard if updating every time for every release instead of doing it once in 3 months :-)

@SVilgelm SVilgelm merged commit 64d823c into golangci:master Dec 28, 2020
ashanbrown pushed a commit to ashanbrown/golangci-lint that referenced this pull request Feb 20, 2021
@denis-tingaikin @ldez @ashanbrown
Update assets for v1.34.0 (golangci#1588)
d7a58a3 
* generate stuff for v1.34.0

Signed-off-by: Denis Tingajkin <[email protected]>

* chore: update chnagelog.

Co-authored-by: Fernandez Ludovic <[email protected]>
@ldez ldez added this to the v1.34 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SVilgelm SVilgelm SVilgelm approved these changes

@ldez ldez ldez approved these changes

Assignees

@ldez ldez

Labels
area: ci PR that update CI
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-tingaikin @ldez @SVilgelm