Skip to content

Add version command to print golangci-lint version #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

Add version command to print golangci-lint version #767

merged 1 commit into from
Oct 1, 2019

Conversation

jimen0
Copy link
Contributor

@jimen0 jimen0 commented Oct 1, 2019

This PR implements the version command as discussed in the linked issue.

It follows the same structure as the golangci-lint --version flag.

➜ golangci-lint git:(implement-version-command) ✗ golangci-lint --version
golangci-lint has version (devel) built from (unknown, mod sum: "") on (unknown)
➜ golangci-lint git:(implement-version-command) ✗ golangci-lint version
golangci-lint has version (devel) built from (unknown, mod sum: "") on (unknown)

Fixes #675

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tpounds tpounds added the enhancement New feature or improvement label Oct 1, 2019
tpounds
tpounds approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@tpounds tpounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚢

@tpounds tpounds merged commit 5e54b33 into golangci:master Oct 1, 2019
@jimen0 jimen0 deleted the implement-version-command branch October 2, 2019 07:30
@ldez ldez added this to the v1.20 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpounds tpounds tpounds approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

golangci-lint --version fails on master branch
4 participants
@jimen0 @CLAassistant @tpounds @ldez