Skip to content

Update gosec and add column #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Conversation

rung
Copy link
Contributor

@rung rung commented Jan 3, 2020

What

  • Add Column to gosec result
  • Update gosec to use latest gosec

Output Example

  • Before
main.go:11: G403: RSA keys should be at least 2048 bits (gosec)
	pvk, err := rsa.GenerateKey(rand.Reader, 1024)
  • After
main.go:11:14: G403: RSA keys should be at least 2048 bits (gosec)
	pvk, err := rsa.GenerateKey(rand.Reader, 1024)
	            ^

Why

Signed-off-by: Hiroki Suezawa <[email protected]>
@claassistantio
Copy link

claassistantio commented Jan 3, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tpounds tpounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚢

@tpounds tpounds merged commit 7368dd3 into golangci:master Jan 4, 2020
@tpounds tpounds added enhancement New feature or improvement dependencies Relates to an upstream dependency labels Jan 4, 2020
@rung rung deleted the update-gosec-column branch January 4, 2020 23:35
@ldez ldez added linter: update version Update version of linter and removed dependencies Relates to an upstream dependency labels Jul 14, 2021
@ldez ldez added this to the v1.23 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants