Skip to content

gocritic: update disabled check warning message #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2020
Merged

gocritic: update disabled check warning message #958

merged 1 commit into from
Feb 3, 2020

Conversation

martinsirbe
Copy link
Contributor

Improve gocritic disabled check warning message as per #950.

@claassistantio
Copy link

claassistantio commented Feb 3, 2020

CLA assistant check
All committers have signed the CLA.

@@ -139,8 +139,8 @@ func (s *GocriticSettings) InferEnabledChecks(log logutils.Log) {
enabledChecksSet := stringsSliceToSet(enabledChecks)
for _, disabledCheck := range s.DisabledChecks {
if !enabledChecksSet[disabledCheck] {
log.Warnf("Gocritic check %q was disabled by config, was it's not enabled, no need to disable it",
disabledCheck)
log.Warnf("Gocritic check %q was explicitly disabled via config. However, as this check" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is not gofmt-ed with -s (from gofmt)

Suggested change
log.Warnf("Gocritic check %q was explicitly disabled via config. However, as this check" +
log.Warnf("Gocritic check %q was explicitly disabled via config. However, as this check"+

@ernado ernado merged commit 4d165fc into golangci:master Feb 3, 2020
@ernado
Copy link
Member

ernado commented Feb 3, 2020

Thank you!

@martinsirbe martinsirbe deleted the update-warn-msg branch February 4, 2020 09:40
@ldez ldez added this to the v1.23 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants