Skip to content

Update version and fix samples for 0.8.5 release #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 16, 2025

Conversation

MarkDaoust
Copy link
Collaborator

@MarkDaoust MarkDaoust commented Apr 15, 2025

  1. Update version number for 0.8.5 release
  2. Set "Development Status :: 7 - Inactive"
  3. Next releases will pickup the README as the main page on PyPi, so this will show the current readme's "[DEPRECATED]".
  4. Fix broken samples (all samples pass now).
  5. Fix empty GEMINI_API_KEY="" shadowing "GOOGLE_API_KEY".
  6. Fix tests broken by pydantic 2.11
  7. Remove duplicate/orphaned code broken by pydantic2.11 (responder.py)
  8. Sync readme to match Add Support Plan for the repository and deprecation timeline. deprecated-generative-ai-js#462

Change-Id: Ie0b0f883cbe5c8e5427c1d59c1b96bea0dd62fde
Change-Id: I48f3389565d68bc10f1608980298e6f1e384fc37
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Apr 15, 2025
Change-Id: Ibfe397dc19d055867bb8c0e87f9ba107867e4289
Change-Id: I1df220253baf1b2171891ba380a0a3dde8e09a8b
Change-Id: I0fdfc084e8c5e88bab8257eef22065ec5a6189ea
Change-Id: Ie697e2f43b2608cadebfd14d806f3898b064cc3b
Change-Id: I51110cf338bd61d8cf40b3e73ece12b34c951d0c
@MarkDaoust MarkDaoust requested review from IvanLH and Annhiluc April 15, 2025 20:19
Copy link
Contributor

@Annhiluc Annhiluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add reason that google/generativeai/responder.py is deleted to the PR?

Change-Id: I6bc43a471b5558f373f6c514a9dc56a49dd9e677
Change-Id: Ib7aee25dfa0d94fc3c4abd55c28a36211126e883
Change-Id: I8f010a0ff5e45009ce9114d6bfc025e5774c2004
@MarkDaoust
Copy link
Collaborator Author

Add reason that google/generativeai/responder.py is deleted to the PR?

Added to the main description.
Mainly: this was the start of development for a feature that was never completed (forked from content_types.py). It should have been done on a feature branch instead of in main. While the file name doesn't start with an underscore, it's never been mentioned externally.

Anyway, people could be importing it. So maybe this is a bit much to put in a bug fix release. I've copied in the fixed code from content_types.py, minimal update, all the tests pass now.

@MarkDaoust MarkDaoust merged commit f5ac4ed into google-gemini:main Apr 16, 2025
9 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants