fix: use entire env for credential prompting #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the URL and token environment variable are set outside gptscript, then the credential prompting tool needs those variables. In this case, the extraEnv is nil and doesn't allow prompting to work. Additionally, the credential context default is needed when completing the opts for the SDK server. Signed-off-by: Donnie Adams <[email protected]>
cjellick
approved these changes
Jun 5, 2024
tylerslaton
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the URL and token environment variable are set outside gptscript, then the credential prompting tool needs those variables. In this case, the extraEnv is nil and doesn't allow prompting to work.
Additionally, the credential context default is needed when completing the opts for the SDK server.