feat: add support for remote file parsing #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerslaton
requested review from
ibuildthecloud,
thedadams,
njhale,
StrongMonkey and
g-linville
thedadams
reviewed
Jun 8, 2024
thedadams
approved these changes
Jun 10, 2024
pkg/cli/parse.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| // If the content is empty and there was no error, this is not a remote file. Return the file error. |
There was a problem hiding this comment.
nit: comment is out of date.
Signed-off-by: tylerslaton <[email protected]>
tylerslaton
force-pushed
the
parse-remote
branch
from
3e9de59 to
5b0c439
Compare
cjellick
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for remote file parsing. This will mainly be a nice feature for the SDKs as consumers of them can now parse file remotely prior to executing them. Namely, the UI will use this functionality.
How
This is done by exporting
loader.ContentFromURLas a new public function. Theinputpackage then usesloader.ContentFromURLin a newinput.FromURLfunction. This allows all of the same loading logic to apply that GPTScript runs do while also leveraging the same cache that they do. Finally, theparsesubcommand callsinput.FromURLif a file load fails.