enhance: automatically use the generic credential tool for OpenAPI #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
g-linville
commented
Jun 12, 2024
Comment on lines
+414
to
+416
| for _, cred := range t.Parameters.Credentials { | ||
| _, _ = fmt.Fprintf(buf, "Credential: %s\n", cred) | ||
| } |
There was a problem hiding this comment.
We were previously printing the credential tools all on one line, which is no longer supported. This change makes it print each on its own line, which is supported.
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
thedadams,
njhale,
StrongMonkey and
tylerslaton
StrongMonkey
approved these changes
Jun 12, 2024
thedadams
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively simple change that just adds a
Credential:line or two to each tool generated for an OpenAPI definition, if there is some supported security scheme for the particular operation (i.e. API key, HTTP bearer token, HTTP basic auth).This works seamlessly with existing OpenAPI tool examples such as the DigitalOcean agent.