fix: only complete CLI args when running gptscript #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change completed all the options, including setting defaults when running gptscripts. This caused issues with "no-op" defaults being set before they should have. This change will only complete the CLI args and wait for the remaining defaults to be set until all CLI args have be completed. Signed-off-by: Donnie Adams <[email protected]>
thedadams
requested review from
cjellick,
StrongMonkey,
g-linville and
tylerslaton
cjellick
approved these changes
Jun 14, 2024
g-linville
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change completed all the options, including setting defaults when running gptscripts. This caused issues with "no-op" defaults being set before they should have. This change will only complete the CLI args and wait for the remaining defaults to be set until all CLI args have be completed.