fix: misc improvements related to creds and prompting #536
+27
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
g-linville
commented
Jun 24, 2024
pkg/prompt/prompt.go
Outdated
Comment on lines
78
to
83
| if req.Message != "" && len(req.Fields) == 1 && strings.TrimSpace(req.Fields[0]) == "" { | ||
| _, _ = fmt.Fprintln(os.Stderr, req.Message) | ||
| _, _ = fmt.Fprintln(os.Stderr, "Press enter to continue...") | ||
| _, _ = fmt.Fscanln(os.Stdin) | ||
| return "", nil | ||
| } |
There was a problem hiding this comment.
This makes the prompt look a little bit better if all we want to do is display a message to the user instead of getting information from the user.
g-linville
commented
Jun 24, 2024
| @@ -681,7 +681,7 @@ func streamProgress(callCtx *engine.Context, monitor Monitor) (chan<- types.Comp | |||
| CallContext: callCtx.GetCallContext(), | |||
| Type: EventTypeCallProgress, | |||
| ChatCompletionID: status.CompletionID, | |||
| Content: message.String(), | |||
| Content: getEventContent(message.String(), *callCtx), | |||
There was a problem hiding this comment.
This is to prevent credential tool output from leaking to the terminal.
Signed-off-by: Grant Linville <[email protected]>
g-linville
requested review from
thedadams,
njhale,
StrongMonkey,
iwilltry42 and
tylerslaton
StrongMonkey
approved these changes
Jun 25, 2024
thedadams
approved these changes
Jun 25, 2024
Co-authored-by: Donnie Adams <[email protected]> Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.