Skip to content

feat: build credential helpers just in time #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

thedadams
Copy link
Contributor

Instead of building the credential helpers on startup, this change builds them when they are needed. This speeds up start time for the SDK.

@thedadams thedadams requested a review from g-linville June 26, 2024 13:23
Instead of building the credential helpers on startup, this change
builds them when they are needed. This speeds up start time for the SDK.

Signed-off-by: Donnie Adams <[email protected]>
@thedadams thedadams force-pushed the deferred-cred-helper-build branch from 41f7e13 to 638f645 Compare June 26, 2024 13:27
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this out, works great! LGTM

@thedadams thedadams merged commit 6055f37 into gptscript-ai:main Jun 26, 2024
8 checks passed
@thedadams thedadams deleted the deferred-cred-helper-build branch June 26, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants