fix: use GH token for VCS lookups #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
reviewed
Jun 27, 2024
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
g-linville
force-pushed
the
use-gh-env-var
branch
from
1cf9b68 to
18784b0
Compare
g-linville
requested review from
thedadams,
njhale,
StrongMonkey,
iwilltry42 and
tylerslaton
njhale
approved these changes
Jun 28, 2024
iwilltry42
approved these changes
Jun 28, 2024
|
@njhale and I just fixed the claude smoke tests (was a problem in the |
Signed-off-by: Grant Linville <[email protected]>
|
@g-linville Also, just noting that members of the LMK if this isn't the case for you and I can look into it. |
|
Thanks. Yeah I didn't need to add the label but I added it at some point to see if it would change anything while I was troubleshooting, lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we now use the GitHub token for VCS lookups when resolving tools. This can help avoid rate limits.
I also fix the Claude smoke test in this PR, but it runs the old version against this PR, which is why it is still failing.