Chore: Remove unnecessary typecheck linter config #89198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana-pr-automation
bot
added
the
pr/external
|
Thanks for the PR @zeghong - can you please rebase? The linter config has been updated recently. |
|
@hairyhenderson Sorry for the late reply, I've rebase the branch |
hairyhenderson
added
the
no-changelog
auto-merge was automatically disabled
June 25, 2024 07:17
Head branch was pushed to by a user without write access
hairyhenderson
approved these changes
Jun 25, 2024
|
@hairyhenderson Sorry to bother you, is this pull request ready to be merged? |
|
@zeghong sorry, this fell through the cracks... Something went wrong with CI. I'll kick it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This removes unnecessary
typechecklinter setting from.golangci.toml.Why do we need this feature?
The
typechecklinter has been removed from linter list as of golangci-lint v1.54.0 (See Changelog).As they stated in FAQ, "typecheck is not a linter", so activation of
typecheckis enforced. Therefore, the setting in[linters]section is unnecessary. (Also, there are duplicate items in the list.)For more explanation and technical detail: