Skip to content

Represent serialized floats to approximately python float precision #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leszekhanusz
Copy link
Collaborator

Reproduce the changes made in graphql-core PR #164 so that the copy-pasted ast_from_value function in the dsl module stays in sync with the one in graphql-core.

@codecov-commenter
Copy link

Codecov Report

Merging #318 (22f4686) into master (1a1a2ee) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #318   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2135      2138    +3     
=========================================
+ Hits          2135      2138    +3     
Impacted Files Coverage Δ
gql/dsl.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1a2ee...22f4686. Read the comment docs.

@leszekhanusz leszekhanusz merged commit ea96294 into graphql-python:master Apr 11, 2022
@leszekhanusz leszekhanusz deleted the fix_serialized_float_precision branch April 11, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants