Skip to content

Instead of using is_nullish, use a more Pythonic "is None" check. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2015

Conversation

faassen
Copy link
Contributor

@faassen faassen commented Oct 8, 2015

As discussed previously, since NaN does not enter the codebase in the Python implementation, we don't have to have a (non-pythonic, better would be math.isnan) check for it in is_nullish. Replace is_nullish with is comparison with None.

jhgg added a commit that referenced this pull request Oct 8, 2015
Instead of using is_nullish, use a more Pythonic "is None" check.
@jhgg jhgg merged commit 54db657 into graphql-python:master Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants