-
-
Notifications
You must be signed in to change notification settings - Fork 139
Add pytest-benchmark and port the benchmarks from GraphQL.js #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0fe1a77
Add pytest-benchmark and port introspectionFromSchema-benchmark.js
ktosiek 3b8e4b1
Port the parser benchmark
ktosiek 25cf4ce
Port validation benchmark
ktosiek a1f1201
Port SDL validation benchmark
ktosiek 5209006
Port building Schema from AST benchmark
ktosiek ea71ad5
Port building Schema from introspection benchmark
ktosiek 4f2d73d
Don't validate schema when setting up benchmark tests
ktosiek 8f991c8
Merge branch 'master' into benchmarks
Cito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
from graphql import parse, build_ast_schema, GraphQLSchema | ||
|
||
# noinspection PyUnresolvedReferences | ||
from ..fixtures import big_schema_sdl # noqa: F401 | ||
|
||
|
||
def test_build_schema_from_ast(benchmark, big_schema_sdl): # noqa: F811 | ||
schema_ast = parse(big_schema_sdl) | ||
schema: GraphQLSchema = benchmark( | ||
lambda: build_ast_schema(schema_ast, assume_valid=True) | ||
) | ||
assert schema.query_type is not None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
from graphql import build_client_schema, GraphQLSchema | ||
|
||
# noinspection PyUnresolvedReferences | ||
from ..fixtures import big_schema_introspection_result # noqa: F401 | ||
|
||
|
||
def test_build_schema_from_introspection( | ||
benchmark, big_schema_introspection_result # noqa: F811 | ||
): | ||
schema: GraphQLSchema = benchmark( | ||
lambda: build_client_schema( | ||
big_schema_introspection_result["data"], assume_valid=True | ||
) | ||
) | ||
assert schema.query_type is not None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
from graphql import build_schema, parse, execute | ||
from graphql.utilities import introspection_query | ||
|
||
# noinspection PyUnresolvedReferences | ||
from ..fixtures import big_schema_sdl # noqa: F401 | ||
|
||
|
||
def test_execute_introspection_query(benchmark, big_schema_sdl): # noqa: F811 | ||
schema = build_schema(big_schema_sdl, assume_valid=True) | ||
query = parse(introspection_query.get_introspection_query()) | ||
result = benchmark(lambda: execute(schema, query)) | ||
assert result.errors is None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
from graphql import parse, DocumentNode | ||
|
||
# noinspection PyUnresolvedReferences | ||
from ..fixtures import kitchen_sink_query # noqa: F401 | ||
|
||
|
||
def test_parse_kitchen_sink(benchmark, kitchen_sink_query): # noqa: F811 | ||
query = benchmark(lambda: parse(kitchen_sink_query)) | ||
assert isinstance(query, DocumentNode) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
from graphql import build_schema, parse, validate | ||
from graphql.utilities import introspection_query | ||
|
||
# noinspection PyUnresolvedReferences | ||
from ..fixtures import big_schema_sdl # noqa: F401 | ||
|
||
|
||
def test_validate_introspection_query(benchmark, big_schema_sdl): # noqa: F811 | ||
schema = build_schema(big_schema_sdl, assume_valid=True) | ||
query = parse(introspection_query.get_introspection_query()) | ||
result = benchmark(lambda: validate(schema, query)) | ||
assert result == [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
from graphql import parse | ||
from graphql.validation.validate import validate_sdl | ||
|
||
# noinspection PyUnresolvedReferences | ||
from ..fixtures import big_schema_sdl # noqa: F401 | ||
|
||
|
||
def test_validate_sdl_document(benchmark, big_schema_sdl): # noqa: F811 | ||
sdl_ast = parse(big_schema_sdl) | ||
result = benchmark(lambda: validate_sdl(sdl_ast)) | ||
assert result == [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also use benchmark-skip to completely skip them, but I agree this is better. They are probably a bit redundant, but not too slow if they run only as test.