Use Executor for getting responses #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasrcosta
force-pushed
the
use-response-executor
branch
3 times, most recently
from
8036719 to
1b89362
Compare
|
@syrusakbary no interest on this? |
dan98765
suggested changes
Mar 30, 2019
There was a problem hiding this comment.
(@syrusakbary has been very busy and is transitioning a lot of his graphql-python project maintenance to folks in the community; I'm just an interested volunteer...)
This is a great change! @lucasrcosta how do you feel about adding new/updated tests before it gets merged in?
|
Will do @dan98765! o> |
Cito
force-pushed
the
master
branch
2 times, most recently
from
d21bdd4 to
c781f01
Compare
lucasrcosta
force-pushed
the
use-response-executor
branch
3 times, most recently
from
7251d70 to
96f5a0d
Compare
Use an Executor of the same type as configured to get backend responses.This leverages the batching functionality, allowing batched requests to be processed concurrently.
lucasrcosta
force-pushed
the
use-response-executor
branch
from
96f5a0d to
786849b
Compare
|
@dan98765 is this test enough? |
|
No one to give this a thought? |
|
@dan98765 @syrusakbary Is there anything else preventing this from being merged? |
|
@dan98765 can you approve your change requests? this looks good to merge to me |
dan98765
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an Executor of the same type as configured to get backend responses.
This leverages the batching functionality, allowing batched requests to be processed concurrently.