Skip to content

Don't use executor in run_http_query when return_promise=True #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2020
Merged

Don't use executor in run_http_query when return_promise=True #33

merged 2 commits into from
Jan 23, 2020

Conversation

blazewicz
Copy link
Contributor

fixes #32

@blazewicz blazewicz force-pushed the return-promise-option branch 3 times, most recently from 3e9d42d to 24fbb7f Compare December 21, 2019 12:34
@blazewicz blazewicz force-pushed the return-promise-option branch from 24fbb7f to 845ea85 Compare December 21, 2019 20:36
@ItsAshleyJ182
Copy link

This all looks good to me, I discovered this issue in my application as well.

@Cito I notice you're one of the main contributors to this project after @syrusakbary opened it up to the community, are there any contributing/review guidelines we should be following?

@ItsAshleyJ182
Copy link

@Cito is there anyone else who has write access to this repository? We should really address this issue

@Cito
Copy link
Member

Cito commented Jan 23, 2020

@banjoanderson was swamped with work - will have a look later today.

@Cito Cito merged commit b99207a into graphql-python:master Jan 23, 2020
@Cito
Copy link
Member

Cito commented Jan 23, 2020

Thanks a lot for working on this. I will create a 1.2 release containing this fix.

@blazewicz blazewicz deleted the return-promise-option branch January 23, 2020 20:40
@Cito
Copy link
Member

Cito commented Jan 23, 2020

Version 1.2.0 has been released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsAshleyJ182 ItsAshleyJ182 ItsAshleyJ182 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

broken support for AsyncioExecutor
3 participants
@blazewicz @ItsAshleyJ182 @Cito