Release v14.0.0

[leebyron]

Let's coordinate on releasing this final version, @IvanGoncharov and @mjmahone.

I believe #1382 is the final blocker based on previous discussions I've had with you all about what we'd like to include. If there's anything else we should have blocking this release let me know.

Next steps are to write up the full release notes with special mentions of breaking changes, then finally push the version bump and commit tag.

[IvanGoncharov]

@leebyron There is a couple issue I think we need to discuss:

1. After Merge extendType functionality changes from #1322 #1373 merged we still have a few related issues:
   1. validateSchema doesn't use nodes from new extensionASTNodes properties.
   2. extend scalar is not supported
2. I also think it's very critical to add validation of directives in SDL since as noted here no one validates them correctly at the moment. That will lead to a situation very similar to the recent Allow interfaces to have no implementors. Since spec defines set of validation rules but no one implements them. Probably we shouldn't enforce Directives Are Unique Per Location until Limiting the scope of "Directives Are Unique Per Location" validation graphql-spec#429 resolved but all other validation should be implemented e.g. require the schema to contain applied directives, correct directive arguments, etc.
3. Should we switch from IE9 to IE11 especially since IE9 & IE10 not fully supported by babel?
   Don't know a lot about ios but maybe it also worth to update.
   

   graphql-js/.babelrc.js

   Lines 7 to 8 in f2070c8

   	"ie 9",
   	"ios 9",

4. I think we should use this opportunity to clarify on deprecated functionality. I propose the following:
   1. Drop support for onOperation, onFragment, onField since they were deprecated two years ago.
   2. Explicitly say that following functions would be removed in 15.0.0 release isValidJSValue,isValidLiteralValue,introspectionQuery.
   3. Explicitly say that support for legacy SDL syntax would be removed in 16.0.0. Also, we can recommend all 3rd-party tools and libraries to stop supporting it by default and require a user to explicitly specify that he wants to use legacy SDL syntax through configuration/option.

[IvanGoncharov]

@leebyron I also forget to mention one more breaking change which is not super important but a huge quality of life improvement. parseLiteral should throw on invalid values similar to parseValue.

graphql-js/src/type/scalars.js

Lines 56 to 64 in f2070c8

	parseLiteral(ast) {
	if (ast.kind === Kind.INT) {
	const num = parseInt(ast.value, 10);
	if (num <= MAX_INT && num >= MIN_INT) {
	return num;
	}
	}
	return undefined;
	},

Same goes for enums:

graphql-js/src/type/definition.js

Lines 1105 to 1113 in f2070c8

	parseLiteral(valueNode: ValueNode, _variables: ?ObjMap<mixed>): ?any /* T */ {
	// Note: variables will be resolved to a value before calling this function.
	if (valueNode.kind === Kind.ENUM) {
	const enumValue = this.getValue(valueNode.value);
	if (enumValue) {
	return enumValue.value;
	}
	}
	}

[leebyron]

@IvanGoncharov want to open a new issue for throwing from parseLiteral? Not sure I totally understand the use case and want to discuss further but don't want to hijack this issue

[leebyron]

I just put up PRs to address your point 4, @IvanGoncharov. Are you interested in working on point 1 or 2? I'll start looking into point 3.

[leebyron]

To follow up on point 3, changing "ie 9" to "ie 11" has no impact on compiled output (tested with diff -r), only removing both ie and ios entries causes any change - for example then const is not compiled to var - however I don't think this is something we want to do, so I'll suggest leaving that configuration as is for now.

[leebyron]

I created new tasks for the remaining issues you brought up and created a milestone so we keep track of them: v14.0.0 Milestone

If you (or anyone else who might be reading this? @mjmahone?) is interested in helping work through these that would be a huge help in getting this release out this week.

[alexmylonas]

Excuse my ignorance, but why you jumped from v0.13 -> v14? Is this misname or is this a common practice, just curious!