Skip to content

fix: ci checks #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: source
Choose a base branch
from
Open

fix: ci checks #1990

wants to merge 6 commits into from

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Apr 28, 2025

Noticed the new docs validation job was failing #1983. This PR fixes the syntax and merges all the checks in one job as multiple jobs.

CleanShot 2025-04-28 at 13 11 31@2x
source: https://github.com/graphql/graphql.github.io/actions/runs/14702757073

cc @sarahxsanders

Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 0:22am

@saihaj
Copy link
Member Author

saihaj commented Apr 28, 2025

so looks like this one fails because our this CI job can't build the Conf websites since we are missing API keys on GitHub Actions CI.

CleanShot 2025-04-28 at 18 05 52@2x

@sarahxsanders @benjie @Urigo options we have to unblock this

  1. We ignore the /conf/** subpaths since for each conf version we have an API key to build. I am not even sure what the rate limits are so probably a wise idea.
  2. Someone helps me get the API keys (we have these on our vercel) and configure on GitHub CI.

@benjie
Copy link
Member

benjie commented Apr 28, 2025

I'd go with option 1 for now, seems the safest least likely to break CI flows 👍

@sarahxsanders
Copy link
Contributor

I agree with @benjie

@saihaj
Copy link
Member Author

saihaj commented Apr 29, 2025

actually we can't do 1 because I can't find a way to ignore building the conf site 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants