Render false literal as “false”

[scoot557]

When trying to set a data attribute to boolean values -- if the value is false, it sets it to "".

displayed here: http://jsbin.com/puviteme/1/edit
You can inspect via DOM inspector, or run this in the jsbin console to confirm

$('li').eq(0).data('value');
""
$('li').eq(1).data('value');
true

[akhoury]

+1

relevant SO question

[kpdecker]

I can see the desire here, will have to weigh the consequences of changing this behavior as it could be a very much breaking change, but it appears that mustache js impl does render false as the toString version.

In the mean time the SO question does offer a number of valid work arounds to handle this case safely.

[kpdecker]

@wycats any opinions on this? I'm inclined to move towards rendering false values for interpolation statements as these must be explicitly set (vs. undefined) and feels similar to zero in terms of general usage to me but I'm worried about this breaking large swaths of users.

[kpdecker]

In absence of any dissenting voices I'm going to move forward with changing the templates to render false as the to string value. This feels like the right thing and if we are going to do it, at 2.0 is the time that it can be done without massively pissing off (most) users.

[kpdecker]

Released in v2.0.0-beta.1

[Twipped]

I know I'm a little late on this, but I have a dissenting voice...

I just tried updating my helpers-hoard library to 2.0 to see what would happen, and many of my tests are failing because the templates are rendering as "false" instead of "".