Skip to content

Remove imperative filling functions _ #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 12, 2021
Merged

Remove imperative filling functions _ #105

merged 6 commits into from
Sep 12, 2021

Conversation

srush
Copy link
Collaborator

@srush srush commented Sep 12, 2021

This PR moves from the modifying tensors inline to instead using torch.where to create new ones.

This has a couple of advantages namely :

  • fixing the broken build code
  • removing lots of repeated semiring logic
  • unifying this with much of the jax code.

@srush srush mentioned this pull request Sep 12, 2021
Closed
@srush srush merged commit e51fecc into master Sep 12, 2021
@JohnReid JohnReid mentioned this pull request Sep 30, 2021
Open
@JohnReid JohnReid mentioned this pull request Oct 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@srush