Newline character added after all comments when refactoring is applied.

[Friede80]

Before:

After applying the Eta Reduce hint (the fact that the hint is not actually applied is a known issue with apply-refact, but the newline issue manifests when applying any hint)

Relevant log output:

2017-08-20 22:45:42.5956108 [ThreadId 6] - applyHint:ideas=[C:\Users\Friede\AppData\Local\Temp\ghc-mod94877\Main2292916541.hs:6:1: Warning: Eta reduce
Found:
  foo x = head x
Why not:
  foo = head
]
2017-08-20 22:45:42.5996146 [ThreadId 6] - applyHint:commands=[("C:\\Users\\Friede\\AppData\\Local\\Temp\\ghc-mod94877\\Main2292916541.hs:6:1: Warning: Eta reduce\nFound:\n  foo x = head x\nWhy not:\n  foo = head\n",[])]
2017-08-20 22:45:42.7359376 [ThreadId 6] - applyHint:applied="-- My Comment 1\r\nmain :: IO ()\nmain = putStrLn \"Hello World\"\n\n-- My Comment 2\r\nfoo x = head x\n\n-- Another Comment\r\n\nbaz = undefined\n"
2017-08-20 22:45:42.7399396 [ThreadId 6] - applyHint:diff=WorkspaceEdit {_changes = Just (fromList [(Uri {getUri = "file:///e%3A/Coding/TestProj/app/Main.hs"},List [TextEdit {_range = Range {_start = Position {_line = 0, _character = 0}, _end = Position {_line = 0, _character = 15}}, _newText = "-- My Comment 1\r"},TextEdit {_range = Range {_start = Position {_line = 4, _character = 0}, _end = Position {_line = 4, _character = 15}}, _newText = "-- My Comment 2\r"},TextEdit {_range = Range {_start = Position {_line = 7, _character = 0}, _end = Position {_line = 7, _character = 18}}, _newText = "-- Another Comment\r"}])]), _documentChanges = Nothing}

I am on Windows 10. I suspect some issue with Windows line endings, because of the appearance of \r in the diff. But the file is using Unix line endings.

[Ciantic]

See this: lspitzner/brittany#4

What does Format Document does to you? To me it adds newlines on every line with Windows 10 as well.

[lspitzner]

Having tested brittany in isolation (both executable and library), it seems unlikely that brittany is the cause for this issue. At worst, it might replace \r\n with \n. I have not attempted to reproduce via HIE. I think a good next step would be to replace brittany with some "identity formatter" in the plugin and see how that behaves.

[k0aaa]

It seems this is a problem with the vsCode integration, not the HIE server

[k0aaa]

have you tried formatting the entire document?

[nponeccop]

This is probably a duplicate of #397

@lspitzner can you check that whether the problem happens to LF-separated (unix-style) files?