Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Build simplifications #1168

Merged
merged 13 commits into from
Apr 20, 2019
Merged

Build simplifications #1168

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8fd5cba
improve consistency in the install.hs script
samuelpilz Apr 8, 2019
e0fb0a6
include @fendor's comments
samuelpilz Apr 9, 2019
aa5ea40
check version of existing cabal before using that
samuelpilz Apr 9, 2019
36b0f99
implement check for `stack` version
samuelpilz Apr 13, 2019
0d2e6fa
use the compiler from shake to install Cabal
samuelpilz Apr 13, 2019
cadcfe5
change helper functions to always use shake-yaml or specific ghc-base…
samuelpilz Apr 13, 2019
7a97429
document that cabal new-build will work on windows in next release
samuelpilz Apr 13, 2019
a7bb6e9
fix documentation comments
samuelpilz Apr 16, 2019
1fffd94
add current stack version to error about too old stack version
samuelpilz Apr 16, 2019
5b0d0de
add required stack version to error message
samuelpilz Apr 16, 2019
c28a4be
correct the readme to match the new docs targets in install.hs
samuelpilz Apr 17, 2019
e03b5e5
dynamically load hie-versions and exclude `8.6.3` for windows
samuelpilz Apr 18, 2019
b51def0
sort the found supported ghc-versions
samuelpilz Apr 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions install.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ checkStack = do
stackVersion & trim & readP_to_S parseVersion & filter
(("" ==) . snd)
unless (parsedVersion >= makeVersion [1, 9, 3]) $ do
liftIO $ putStrLn $ embedInStars stackExeIsOldFailMsg
error stackExeIsOldFailMsg
liftIO $ putStrLn $ embedInStars $ stackExeIsOldFailMsg stackVersion
error $ stackExeIsOldFailMsg stackVersion


stackBuildHie :: VersionNumber -> Action ()
Expand Down Expand Up @@ -561,7 +561,8 @@ cabalInstallNotSuportedFailMsg =
++ "If this system has been falsely identified, please open an issue at:\n\thttps://github.com/haskell/haskell-ide-engine\n"

-- | Error message when the `stack` binary is an older version
stackExeIsOldFailMsg :: String
stackExeIsOldFailMsg =
stackExeIsOldFailMsg :: String -> String
stackExeIsOldFailMsg stackVersion =
"The `stack` executable is outdated.\n"
++ "found version is `" ++ stackVersion ++ "`.\n"
++ "Please run `stack upgrade` to upgrade your stack installation"