Code action order could prefer fixes over disabling warnings

[andys8]

TL;DR

Code actions are ordered in a way where the most likely option is on the bottom.

Issue

I'm often using code actions to organize imports and remove the ones that aren't necessary. The option that is use the most often ("Remove all redundant imports") is the last option of the menu. And I think most of the time "Disable ... warnings" is the first option. "Make all imports implicit" seems not relevant here.

One issue is that one needs to move to the end of the list each time. But for example in CoC (Vim) coc-fix-current defines the top code action as default and will execute it. So changing the order could be an improvement.

Potential Improvement

Change the order of code actions to (try to) match the most likely behavior. E.g. move "disable warnings" to the bottom of the suggested code actions by default.

Probe Tools

haskell-language-server version: 1.3.0.0 (GHC: 8.6.5) (PATH: /home/andreas/.local/bin/haskell-language-server-wrapper) (GIT hash: e7c5e90b6df5dff2760d76169eddaea3bdd6a831)
Tool versions found on the $PATH
cabal:          3.2.0.0
stack:          2.7.3
ghc:            8.10.4

Config

https://github.com/andys8/dotfiles/blob/3c1d32349ffaf4c1ab840f7b340746846fb5e522/coc-settings.json#L34-L55

[July541]

Hello, I can only get this hint, am I missing something?

[jneira]

Mmm i think in vim all the code actions are shown, not only the associated with the diagnostic, in vscode you could see them clicking in the light bulb at the start of the expression

[July541]

@jneira Seems no, all I can see while clicking the bulb is just the one hint.

[July541]

It turns out I don't know when my hls doesn't work as before, I remember it can suggest removing unused import.

[jneira]

Maybe related with #2013??, does add import suggestions still works for you?

[jneira]

The existence of remove unused imports is being exercised here afaics:

haskell-language-server/test/functional/FunctionalCodeAction.hs

Line 353 in 9207050

redundantImportTests :: TestTree

[pepeiborra]

You may need to enable -Wredundant-imports or similar in your project.

[jneira]

Oh yeah i forgot that "little" detail, thanks
It should be documented though (in an note adding the feature in readme?)

[July541]

@pepeiborra Yes, it works! My order is a little different from the author's.

@jneira I think enable -Wall to single file has more advantages.

[jneira]

@jneira I think enable -Wall to single file has more advantages.

Yeah we are doing it in hls itself for example, but i think we have to be precise in the documentation and note that this concrete warning (mentioning -Wall) is needed to make those code actions work at all.

[berberman]

If I understand correctly, the current display order of code actions is up to how handlers are concatenated, which I think is hard to track around ghcide and HLS plugins. Moreover, take pragmas plugin as example, we want adding pragmas be the top priority in most cases (though it‘s supposed to be now, since parsing errors or typechecking errors caused by missing pragmas will prevent ghc from producing warnings), but disabling warnings be the lowest. This doesn't seem feasible by simply reordering handlers.