Skip to content

hls vscode-extension-schema generates a wrong config type #2423

Open
@jneira

Description

@jneira

The command outputs for wingaman hole severity option:

 "haskell.plugin.tactics.config.hole_severity": {
        "type": "string",
        "scope": "resource",
        "enumDescriptions": [
            "error",
            "warning",
            "info",
            "hint",
            "none"
        ],
        "default": null,
        "description": "The severity to use when showing hole diagnostics. These
 are noisy, but some editors don't allow jumping to all severities.",
        "enum": [
            1,
            2,
            3,
            4,
            null
        ]
    },

but its type should be integer instead string, as we can check in the enum values. It produced abug in the vscode extension fixed when we changed the type to integer

//cc @berberman @isovector

Metadata

Metadata

Assignees

No one assigned

    Labels

    component: cliAbout the pure command line interface of the hls executabletype: bugSomething isn't right: doesn't work as intended, documentation is missing/outdated, etc..

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions