"disable warning" gets ordered high in the fix list

[lf-]

Is your enhancement request related to a problem? Please describe.

When I hit the code action button on unused imports, the "Disable [x] warnings" option is very high up, despite rarely being the right code action to fix the problem at hand. More generally it seems that the disable warning action is always high up on every warning.

Describe the solution you'd like

I would like the most appropriate fix to be first, so I can hit the "fix-first-suggestion" button in my editor to fix my imports. For instance, in this case, the first action should be deleting the unused imports on the current line.

Describe alternatives you've considered

Additional context

Reproduced on 1.7.0.0 but I'm 90% sure it's also a problem on 1.8.0.0.

[michaelpj]

I think in this situation removing the specific redundant import is probably the canonical fix here, and we could just mark it as isPreferred. @andys8 you've shown this kind of problem some love before, want to take a look?

[andys8]

Hey there, the question is if this was addressed with #3167. The PR was merged after 1.8.0.0 was released. It makes sure 3 types of "remove import" code actions will get preferred. My guess is that chances are high this specific issue is fixed, but not released yet.

[lf-]

Oh damn, I'll file a pr to update the work version of hls then. Thanks!

[michaelpj]

Oh yes, for some reason I thought it was a different code action you fixed! Great!