issues with CompletionItemResolve

[bwkam]

Your environment

Which OS do you use?
NixOS

Which version of GHC do you use and how did you install it?
9.6.6, with nix

How is your project built (alternative: link to the project)?

Which LSP client (editor/plugin) do you use?
emacs+lsp-mode
Which version of HLS do you use and how did you install it?
2.9.0.0, using nix
Have you configured HLS in any way (especially: a hie.yaml file)?
No

What's wrong?

some error about SMethod_CompletionItemResolve keeps popping up as I type anything in the buffer
the error is not an emacs problem too, same behavior occurs on vscode (I just tested)
(see below)

Debug information

Error processing message (error "No plugins are available to handle this SMethod_CompletionItemResolve request.
 Plugins installed for this method, but not available to handle this request are:
ghcide-completions does not handle resolve requests for (unable to determine resolve owner)).").

[fendor]

Thank you for the bug report!

I can not reproduce on arch linux with HLS 2.9.0.1 installed via ghcup.
However, I can reproduce the issue with a nixpkgs installed HLS binary.

I am able to reproduce the issue using a nixpkgs installed HLS binary as well as on arch linux with HLS 2.9.0.1 ghc 9.6.6.

[dmitrykvasnikov]

I have the same issue in doomemacs, emacs+lsp-mode , vanilla arch, ghc 9.10.1

[meritamen]

Same here, vanilla emacs+lsp-haskell, macOS Ventura 13.7.1, ghc 9.4.8, hls 2.9.0.1

[bradrn]

I’m seeing the same issue in vanilla Emacs with lsp-haskell, Arch Linux (well, EndeavourOS), GHC 9.4.8, HLS 2.1.0.1

[fendor]

Reading into the code, I don't think there is anything wrong, sometimes additional information can be requested, and sometimes the server doesn't have any additional information. E.g., documentation or type signatures for non-local identifiers.
We can't be that fine-grained in the Protocol, so the client always tries to resolve completion items which sometimes "fails" but the server can still use what they already have.

Is the current behaviour annoying, e.g., does Emacs or vim spam you with errors?

[bwkam]

yeah in emacs, its extremely annoying. a buffer with that error keeps popping up as you type

[fendor]

But this must be a new change in emacs, right? I think we had this behaviour for a while and just now we started to get these reports?

Seemingly, HLS is behaving correctly. I think this issue is resolvable by extending CompletionResolveData with a NothingToResolve and inserting as the default for all completion items.