Hover does not work for type symbols from external packages

[jacg]

... as documented by the tests titled type constructor from other package, value from other package and external class is signature.

To be precise, hover does work for external values, but not types.

[jneira]

The tests mentioned are:

https://github.com/haskell/ghcide/blob/8d478394afe072b02cb40a2a98baadbf1a787eda/test/exe/Main.hs#L2211-L2212

https://github.com/haskell/ghcide/blob/8d478394afe072b02cb40a2a98baadbf1a787eda/test/exe/Main.hs#L2220

[jneira]

I've just test this and goto def to external packages does not work but hover on external values/types does

[jneira]

Test in hls are in:

haskell-language-server/ghcide/test/exe/Main.hs

Lines 2487 to 2488 in d4f5d43

	, test broken yes xtcL5 xtc "type constructor external #248,249"
	, test broken yes xvL20 xvMsg "value external package #249" -- 120

haskell-language-server/ghcide/test/exe/Main.hs

Lines 2517 to 2518 in d4f5d43

	, test broken broken outL45 outSig "top-level signature #310"
	, test broken broken innL48 innSig "inner signature #310"

[Anton-Latukha]

I believe it works now.

[jneira]

Afaik the broken mark in tests should make the test fail if they are fixed. Although maybe they fail for another reason.
In other similar issue i removed the broken mark to check if the test continue failing for the same reason.

[jacg]

I regret that I don't have the time to work on this any more. 😞

Afaik the broken mark in tests should make the test fail if they are fixed.

Yes, that was the original intention when I wrote these tests. IIRC, it did actually work like that, at least at the beginning.

[jneira]

Although maybe they fail for another reason.

It happened to me for the top level signature/inner signature (they are handled in another issue)
I removed the broken mark and both continue failing obviusly. But visually top-level signature was fixed!
The test was failing due to the hover position, slightly different. Fixing hover position in the test made it green.