Skip to content

Limit the number of valid hole fits #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Limit the number of valid hole fits #1914

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
31757fe
Limit the number of valid hole fits
expipiplus1 Jun 13, 2021
e822724
Don't override user specified hole fitting parameters
expipiplus1 Jun 13, 2021
2b64ec2
Merge branch 'master' into joe-max-holes
pepeiborra Jun 15, 2021
c935a91
Merge branch 'master' into joe-max-holes
isovector Jun 25, 2021
f8a21c0
Merge branch 'master' into joe-max-holes
Ailrun Jun 25, 2021
d8ca069
Merge branch 'master' into joe-max-holes
jneira Jul 10, 2021
212947a
Merge branch 'master' into joe-max-holes
jneira Jul 14, 2021
6ae7347
Merge branch 'master' into joe-max-holes
jneira Jul 14, 2021
ec54ea1
Merge branch 'master' into joe-max-holes
jneira Aug 1, 2021
a2cd004
Merge branch 'master' into joe-max-holes
jneira Sep 1, 2021
ed4f5ed
Merge branch 'master' into joe-max-holes
jneira Sep 2, 2021
dde1a24
Merge branch 'master' into joe-max-holes
jneira Sep 2, 2021
b9797c4
Merge branch 'master' into joe-max-holes
Anton-Latukha Dec 21, 2021
abfcaa6
m fx
Anton-Latukha Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ghcide/src/Development/IDE/GHC/Compat.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ import Data.List (foldl')
import Data.List (foldl', isSuffixOf)
#endif

import Control.Applicative ((<|>))
import qualified Data.Map as M
import DynamicLoading
import Plugins (Plugin (parsedResultAction),
Expand Down Expand Up @@ -303,7 +304,7 @@ setUpTypedHoles df
$ df
{ refLevelHoleFits = Just 1 -- becomes slow at higher levels
, maxRefHoleFits = Just 10 -- quantity does not impact speed
, maxValidHoleFits = Nothing -- quantity does not impact speed
, maxValidHoleFits = maxValidHoleFits df <|> Just 10 -- quantity does not impact speed
}


Expand Down