-
-
Notifications
You must be signed in to change notification settings - Fork 387
Add option for setting manual path to Fourmolu binary #3860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
However, the idea is the same, if the config option is either |
Can we ask the user's shell to expand the path? That's the limiting case of what we want, right? |
Returning to this: I think it's pretty sensible for HLS to expect an actual full path, and for it to be the job of the client to shell-expand paths or whatever. So I think the current implementation of this seems fine. Should we update and merge this? |
Yeah, sure. If anyone really wants to add expansion then there's nothing lost by that being a second PR. |
LGTM, maybe we can update merge this. |
I should probably look in to making this work more like
serverExecutablePath
, where it's empty by default, and allows expands~
. But I'm not sure where that logic lives - I see no results in the whole codebase when searching for "serverExecutablePath".