-
-
Notifications
You must be signed in to change notification settings - Fork 388
Add performace diff benchmarks #4203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performace diff benchmarks #4203
Conversation
…nt between two version
I think it is ready now, https://github.com/haskell/haskell-language-server/actions/runs/8926967770/job/24520033550?pr=4203. Display result is showing diff percentage in addition |
Could we emit some more information in the job to give some context for what these mean? It's not clear necessarily from looking at it. Also, are those numbers real? Do we really get random 1429% changes on stuff? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the code really, but maybe it needs some more comments? :)
Co-authored-by: Michael Peyton Jones <[email protected]>
Co-authored-by: Jan Hrcek <[email protected]>
Co-authored-by: Jan Hrcek <[email protected]>
Yes, extream case could happen for small number division, like |
I added a header
|
add something like this in benchmark result to easily view the performance diffferent like what we did for the svg.