Skip to content

Capitalization of "Replace" #4509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2025
Merged

Conversation

dschrempf
Copy link
Contributor

Fixes #4508. I am not sure if I caught all usages, there might also be other phrases I did not look for (i.e., other than "Replace ...").

Also, I had to hide an import (resolveCompletion) which is a bit werid.

I also ignored an editor configuration file.

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fendor fendor requested review from jhrcek and soulomoon March 1, 2025 14:49
Copy link
Collaborator

@soulomoon soulomoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

PS: I think adding emacs ignore session in gitignore help dev use emacs.

@fendor fendor merged commit 980c846 into haskell:master Mar 1, 2025
36 checks passed
@dschrempf dschrempf deleted the capitalization branch March 1, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capitalization of code actions with the same name should be identical
3 participants