Skip to content

Docstrings and documentation for haskell-process-path-*. #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2016

Conversation

mikesperber
Copy link
Contributor

(In the wake of #1112.)

"The path for starting ghci.
This can either be a single string or a list of strings, where the
first elements is a string and the remaining elements are arguments,
which will be prepended to `haskell-process-args-gci`."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: s/gci/ghci/g. Same with other docstrings. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracjan Polak [email protected] writes:

@@ -115,19 +115,28 @@ when showing type information about symbols."

(defcustom haskell-process-path-ghci
"ghci"

  • "The path for starting ghci."
  • "The path for starting ghci.
    +This can either be a single string or a list of strings, where the
    +first elements is a string and the remaining elements are arguments,
    +which will be prepended to haskell-process-args-gci."

Typo: s/gci/ghci/g. Same with other docstrings. Thanks.

Done.

Regards,
Mike

@mikesperber mikesperber force-pushed the haskell-process-path-stuff branch from 16962c7 to 208be76 Compare February 6, 2016 13:20
@mikesperber mikesperber force-pushed the haskell-process-path-stuff branch from 208be76 to b0a0c55 Compare February 6, 2016 15:52
gracjan added a commit that referenced this pull request Feb 6, 2016
Docstrings and documentation for haskell-process-path-*.
@gracjan gracjan merged commit d4e2e33 into haskell:master Feb 6, 2016
@gracjan
Copy link
Contributor

gracjan commented Feb 6, 2016

Perfect, thanks.

Have you seen anything else you could help with?

@mikesperber
Copy link
Contributor Author

Not at the moment. I'm afraid I'm only a casual Haskell, and, hence, haskell-mode, user. But I'll keep an eye open, as always.

@gracjan
Copy link
Contributor

gracjan commented Feb 8, 2016

How about issue #975? There were six places where haskell mode invokes external programs and those could use informative error handling. We get regular issue reports about missing executables. Do you think you could tackle #975?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants