Fix #1146 by treating . as punctuation #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `haskell-cabal-mode` with the point indicated with the vertical bar
below, `forward-char` should leave the point after "Some" instead of
after "Type".
Exposed-Modules: |Some.Internal.Type
This was caused by the following line:
(modify-syntax-entry ?. "w" st)
Which makes "." a word constituent instead of a punctuation character.
This was added in aa97009, "merge
caballero with haskell-cabal". The fix: remove the line above.
|
I wonder what will break if we merge this... |
|
When I tried to do the same thing for hyphens, as suggested by bergey in #1146, many tests started failing. The combination of |
|
Lets wait the usual day before merging. If nobody protests by tomorrow we will merge it. |
|
Thanks! (: |
|
@mrBliss Thanks for looking into the hyphens. I'll take a shot at them when I have (a lot) more time. |
gracjan
added a commit
that referenced
this pull request
Feb 13, 2016
Fix #1146 by treating . as punctuation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
haskell-cabal-modewith the point indicated with the vertical bar below,forward-charshould leave the point afterSomeinstead of afterType.This was caused by the following line:
Which makes "." a word constituent instead of a punctuation character. This was added in aa97009, "merge caballero with haskell-cabal". The fix: remove the line above.