Added font lock tests for pattern synonyms (for #1313) #1337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote tests for the font lock issues with the
pattern
keyword, as discussed in #1313.Please check if the way I used
check-properties
is correct, since:check-properties
each describe the fact that a token should be fontified a particular way in all the test strings given in the first argument (the alternative interpretation is that the triplets describe a series of fontifications for each token in order, and since none of the existing tests duplicate the first element of a triple, it's ambiguous which it is).t
as the second element of each triple, which I am not sure about either. This element is the "syntax" of the token, but I don't know enough about Emacs fontification to know what that means.The
haskell-no-pattern-1
andhaskell-no-pattern-2
tests currently pass, so I commented out the:expected-result :failed
so as to prevent an error.cc: @gracjan
EDIT: fun fact, this is pull request number 1337 on haskell-mode :D