prompt2 support and multi-line #1341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expects the default prompt to end in "> " like in ghci. The default prompt2 will then be as in ghci (ending in "| ").
* Using indent-relative explicitly disables some unwanted heuristics that indent-according-to-mode uses. I've found that this way is better, but it could certainly use improvement. * Make haskell-interactive-mode-multi-line properly indent the expression. * haskell-interactive-mode-cleanup-response is now useless as far as I can tell.
|
Looks nice. Will haskell-mode know if GHCi entered multiline mode? That could be useful to suspend for example company completions. |
|
I couldn't find a direct way to do that, but one could perhaps check to see if the prompt2 was at the beginning of the line and use that information. Instead of just setting prompt2's font-lock property, one could also set an extra text property to make this easier. That could go in a different PR I suppose. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a couple oddities still left, but I think this should improve the state of multi-line support in the REPL.
:set +mC-jindents a bit more like you'd expectFixes #915
Fixes #1278